[PATCH] D37123: [dwarfdump] Pretty print location expressions and location lists
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 24 16:59:31 PDT 2017
aprantl added inline comments.
================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h:91
+
+ /// \brief An iterator to go through the expression operations.
+ class iterator
----------------
We use autobrief in our Doxygen configuration.
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp:106
+ static DescVector &Descriptions = getDescriptions();
+ assert(OpCode < Descriptions.size());
+ return Descriptions[OpCode];
----------------
Does this assert on invalid DWARF? Or is this an internal consistency check?
https://reviews.llvm.org/D37123
More information about the llvm-commits
mailing list