[PATCH] D37065: Ensure standard pseudo instructions (TargetOpcode::*) are compatible with guessInstructionProperties=0
Quentin Colombet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 24 17:02:24 PDT 2017
qcolombet added inline comments.
================
Comment at: include/llvm/Target/Target.td:831
let hasCtrlDep = 1;
+ let hasSideEffects = 1;
let isNotDuplicable = 1;
----------------
Should be 0 IMHO
================
Comment at: include/llvm/Target/Target.td:839
let hasCtrlDep = 1;
+ let hasSideEffects = 1;
let isNotDuplicable = 1;
----------------
Ditto
================
Comment at: include/llvm/Target/Target.td:847
let hasCtrlDep = 1;
+ let hasSideEffects = 1;
let isNotDuplicable = 1;
----------------
Ditto
================
Comment at: include/llvm/Target/Target.td:915
let AsmString = "BUNDLE";
+ let hasSideEffects = 1;
}
----------------
Ditto
https://reviews.llvm.org/D37065
More information about the llvm-commits
mailing list