[PATCH] D37051: Model cache size and associativity in TargetTransformInfo

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 23:40:40 PDT 2017


asb added inline comments.


================
Comment at: include/llvm/Analysis/TargetTransformInfoImpl.h:348
+    case TargetTransformInfo::CL_L2D:
+      return llvm::Optional<unsigned>();
+    }
----------------
Shouldn't this have something like:
````
default:
  llvm_unreachable("Unknown TargetTransformInfo::CacheLevel")
```


https://reviews.llvm.org/D37051





More information about the llvm-commits mailing list