[PATCH] D31037: [EarlyCSE] hoist div/rem when sibling op exists (PR31028)

[Daniel Berlin via llvm-commits]

So, the part it will fit in with will be when we do insertion for load
coercion, but even then it's a bit of a wonky fit.
I'm not opposed to just having hoist-div-rem, sounds completely reasonable
to me!

On Wed, Aug 23, 2017 at 4:05 PM, Sanjay Patel via Phabricator <
reviews at reviews.llvm.org> wrote:

> spatel added a comment.
>
> In https://reviews.llvm.org/D31037#714685, @dberlin wrote:
>
> > (i am generalizing the ability to have instructions that are not in the
> IR in the value number tables, for NewGVN, but no reason to depend on that
> for now)
>
>
> I (finally) got around to looking at NewGVN by way of PR34228 (
> https://bugs.llvm.org/show_bug.cgi?id=34228 ), and this functionality
> doesn't fit there either based on my limited understanding.
>
> We don't want to keep adding weird stuff into existing passes, so are
> there objections to making this into a new single-purpose "hoist-div-rem"
> pass just for this transform?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D31037
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170823/36ff2588/attachment.html>