[PATCH] D31037: [EarlyCSE] hoist div/rem when sibling op exists (PR31028)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 16:05:57 PDT 2017


spatel added a comment.

In https://reviews.llvm.org/D31037#714685, @dberlin wrote:

> (i am generalizing the ability to have instructions that are not in the IR in the value number tables, for NewGVN, but no reason to depend on that for now)


I (finally) got around to looking at NewGVN by way of PR34228 ( https://bugs.llvm.org/show_bug.cgi?id=34228 ), and this functionality doesn't fit there either based on my limited understanding.

We don't want to keep adding weird stuff into existing passes, so are there objections to making this into a new single-purpose "hoist-div-rem" pass just for this transform?


Repository:
  rL LLVM

https://reviews.llvm.org/D31037





More information about the llvm-commits mailing list