[PATCH] D37051: Model cache size and associativity in TargetTransformInfo

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 14:48:42 PDT 2017


asb added a comment.

In https://reviews.llvm.org/D37051#850795, @fhahn wrote:

> Agreed, Returning the number of cache lines as result of getCacheSize wouldn't be a good idea.
>
> I meant using the cache line size in X86TTIImpl::getCacheSize. This was just a minor potential nit, I think either way is fine.


Ah, sorry for the misunderstanding. I suspect that the cost of potential confusion outweighs the potential benefit of mistakenly setting a cache size that isn't a multiple of the cache line size, but as you say it's a minor thing and either way would work.


https://reviews.llvm.org/D37051





More information about the llvm-commits mailing list