[PATCH] D37051: Model cache size and associativity in TargetTransformInfo
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 23 14:43:08 PDT 2017
fhahn added a comment.
In https://reviews.llvm.org/D37051#850696, @asb wrote:
> Size in bytes makes most sense to me. The first thing any caller is going to do is convert away from cache lines to bytes or kilobytes anyway.
Agreed, Returning the number of cache lines as result of getCacheSize wouldn't be a good idea.
I meant using the cache line size in X86TTIImpl::getCacheSize. This was just a minor potential nit, I think either way is fine.
https://reviews.llvm.org/D37051
More information about the llvm-commits
mailing list