[PATCH] D36788: The issues with X86 prefixes

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 15:47:42 PDT 2017


craig.topper added inline comments.


================
Comment at: lib/Target/X86/Disassembler/X86DisassemblerDecoder.cpp:295
 {
+  if (insn->mode == MODE_64BIT) {
+    uint8_t nextByte;
----------------
What about 32-bit mode?


================
Comment at: lib/Target/X86/Disassembler/X86DisassemblerDecoder.cpp:306
+      //      it's not mandatory prefix
+      //  3. if (nextByte >= 0x40 && nextByte <= 0x4f) it's REX and wee need
+      //     0x0f exactly after it to be mandatory prefix
----------------
wee->we


https://reviews.llvm.org/D36788





More information about the llvm-commits mailing list