[PATCH] D36907: [codeview] support more DW_OPs for more complete debug info

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1009
+      auto Op = DIExpr->expr_op_begin();
+      while (Supported && Op != DIExpr->expr_op_end()) {
+        switch (Op->getOp()) {
----------------
Please factor out the DIExpression parsing into a helper that extracts the fragment info, Deref, Supported, and Offset.

In the long run, we might want to remodel DIExpression so that it encodes this information directly. Right now DIExpressions feel very "stringly-typed": they're just a sequence of integer opcodes and arguments that don't have any clear relationship to each other. Every bit of code that touches them rolls its own parsing.


https://reviews.llvm.org/D36907