[PATCH] D36907: [codeview] support more DW_OPs for more complete debug info

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 09:19:19 PDT 2017


rnk added inline comments.


================
Comment at: llvm/test/CodeGen/X86/codeview-nrvo.ll:73
+!21 = !DILocalVariable(name: "Result", scope: !10, file: !1, line: 10, type: !13)
+!22 = !DIExpression()
+!23 = !DILocation(line: 10, scope: !10)
----------------
aprantl wrote:
> Shouldn't the testcase include a complex expression?
The dbg.declare gets lowered to a DEBUG_VALUE MI instruction with a DW_OP_deref. The complex DIExpression would be more obvious if this were a .mir test case. We probably want all of an IR NRVO test case, an MIR NRVO test case, and hand-crafted IR test cases with complex DIExpressions.


https://reviews.llvm.org/D36907





More information about the llvm-commits mailing list