[PATCH] D36964: [AArch64] ISel legalization debug messages. NFCI.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer updated this revision to Diff 112181.
SjoerdMeijer added a comment.

Hi Alex, thanks for the feedback. The difficulty here is finding the right balance of adding (good) debug messages, and not cluttering the code too much. I think what you are suggesting is what I had in my first revision: that had debug messages in the different AArch64 lowering functions. Then Sam's suggestion was to move some of these messages to SelectionDAG (which we did in https://reviews.llvm.org/D36984), which has 2 advantages: all targets benefit, and it does not clutter up the code. Also, I think this is quite difficult to get completely right the first time. So I think we will have to see what works and what is good and I will be adding more stuff as I go along.  There's a lot of room for improvement here, but I already find these extra debug messages quite useful...

I have addressed your comment about the global address.


https://reviews.llvm.org/D36964

Files:
  lib/Target/AArch64/AArch64ISelLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36964.112181.patch
Type: text/x-patch
Size: 3864 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170822/fc68c0e6/attachment.bin>