[PATCH] D36964: [AArch64] ISel legalization debug messages. NFCI.

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

I think this is a really great initiative. I've added one inline comment. In addition to that, I have a general note. My natural instinct would have been to try to print a more informative message in the caller of the various `is*` functions (such as `isLegalArithImmed`). e.g. might better debug output be produced if debug printing were added to `getAArch64Cmp` instead?



================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:4888
     const GlobalAddressSDNode *GA) const {
-  // The AArch64 target doesn't support folding offsets into global addresses.
+  DEBUG(dbgs() << "Is offset folding legal: AArch64 doesn't support folding "
+        "offsets into global addresses\n");
----------------
If we're going to print a debug message for every call, would it be worth at least dumping the global address symbol as well?


https://reviews.llvm.org/D36964