[PATCH] D36866: [ARM] Add PostRAScheduling option

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 03:19:03 PDT 2017


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

I think this change makes sense and will be convenient when we move ARM codegen to the MachineScheduler. I just have a quick question about adding `FeaturePostRAScheduler` to some processors.



================
Comment at: lib/Target/ARM/ARM.td:876
+                                                         FeatureHasNoBranchPredictor,
+                                                         FeaturePostRAScheduler]>;
 
----------------
What's the reason for adding `FeaturePostRAScheduler` to some processors but not others? 

It seems to be a nonfunctional change, because all changed processors seem to have FeatureThumb2, so `enablePostRAScheduler` would return true anyways.


https://reviews.llvm.org/D36866





More information about the llvm-commits mailing list