[PATCH] D36331: Add ARC backend

[Krzysztof Parzyszek via Phabricator via llvm-commits]

kparzysz added a comment.

I found a few minor things, with those changes it looks good to go to me.



================
Comment at: llvm/lib/Target/ARC/ARCFrameLowering.cpp:100
+    MachineBasicBlock &MBB, MachineBasicBlock::iterator MBBI,
+    bool allocate) const {
+  MachineFunction &MF = *MBB.getParent();
----------------
Please capitalize "allocate" and "scalarAlloc" below.


================
Comment at: llvm/lib/Target/ARC/ARCFrameLowering.cpp:120
+  DEBUG(dbgs() << "Emit Prologue: " << MF.getFunction()->getName() << "\n");
+  auto *afi = MF.getInfo<ARCFunctionInfo>();
+  MachineModuleInfo &MMI = MF.getMMI();
----------------
Could you spell this as AFI to make the capitalization consistent with other abbreviations?


================
Comment at: llvm/lib/Target/ARC/Disassembler/ARCDisassembler.cpp:278
+    return decodeInstruction(DecoderTable32, Instr, Insn32, Address, this, STI);
+  } else {
+    uint32_t Insn16;
----------------
Please avoid "else" after "return".


https://reviews.llvm.org/D36331