[PATCH] D36331: Add ARC backend
Pete Couperus via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 17 11:35:15 PDT 2017
petecoup updated this revision to Diff 111538.
petecoup added a comment.
Hello Krzysztof,
Thanks for taking a look!
This new patch should address your comments here. Please let me know if I missed anything.
- Rebase to trunk.
- Change leading case on a number of functions/parameters/variables. Change debug location names to dl.
- Remove some static_casts by using MF.getSubtarget<ARCSubtarget>() where appropriate.
- Return ARCRegisterInfo* where appropriate.
- Use MBB.findDebugLoc(MBBI) in a number of places where MBBI can be end().
- Remove unnecessary TII variables.
- Remove function names from a number of comments.
- Remove other misleading/unnecessary comments, or commented out code.
- Change int32_t vars to not be declared auto, and remove explicit casts.
- Remove unnecessary isGPR32Register routine, and use ARC::GPR32RegClass.contains instead.
- Use dbgs() << MI for MachineInstrs where appropriate.
- Remove printMemOperand declaration (we use printMemOperandRI).
https://reviews.llvm.org/D36331
Files:
llvm/include/llvm/ADT/Triple.h
llvm/lib/Support/Triple.cpp
llvm/lib/Target/ARC/ARC.h
llvm/lib/Target/ARC/ARC.td
llvm/lib/Target/ARC/ARCAsmPrinter.cpp
llvm/lib/Target/ARC/ARCBranchFinalize.cpp
llvm/lib/Target/ARC/ARCCallingConv.td
llvm/lib/Target/ARC/ARCExpandPseudos.cpp
llvm/lib/Target/ARC/ARCFrameLowering.cpp
llvm/lib/Target/ARC/ARCFrameLowering.h
llvm/lib/Target/ARC/ARCISelDAGToDAG.cpp
llvm/lib/Target/ARC/ARCISelLowering.cpp
llvm/lib/Target/ARC/ARCISelLowering.h
llvm/lib/Target/ARC/ARCInstrFormats.td
llvm/lib/Target/ARC/ARCInstrInfo.cpp
llvm/lib/Target/ARC/ARCInstrInfo.h
llvm/lib/Target/ARC/ARCInstrInfo.td
llvm/lib/Target/ARC/ARCMCInstLower.cpp
llvm/lib/Target/ARC/ARCMCInstLower.h
llvm/lib/Target/ARC/ARCMachineFunctionInfo.cpp
llvm/lib/Target/ARC/ARCMachineFunctionInfo.h
llvm/lib/Target/ARC/ARCRegisterInfo.cpp
llvm/lib/Target/ARC/ARCRegisterInfo.h
llvm/lib/Target/ARC/ARCRegisterInfo.td
llvm/lib/Target/ARC/ARCSubtarget.cpp
llvm/lib/Target/ARC/ARCSubtarget.h
llvm/lib/Target/ARC/ARCTargetMachine.cpp
llvm/lib/Target/ARC/ARCTargetMachine.h
llvm/lib/Target/ARC/ARCTargetStreamer.h
llvm/lib/Target/ARC/ARCTargetTransformInfo.h
llvm/lib/Target/ARC/CMakeLists.txt
llvm/lib/Target/ARC/Disassembler/ARCDisassembler.cpp
llvm/lib/Target/ARC/Disassembler/CMakeLists.txt
llvm/lib/Target/ARC/Disassembler/LLVMBuild.txt
llvm/lib/Target/ARC/InstPrinter/ARCInstPrinter.cpp
llvm/lib/Target/ARC/InstPrinter/ARCInstPrinter.h
llvm/lib/Target/ARC/InstPrinter/CMakeLists.txt
llvm/lib/Target/ARC/InstPrinter/LLVMBuild.txt
llvm/lib/Target/ARC/LLVMBuild.txt
llvm/lib/Target/ARC/MCTargetDesc/ARCInfo.h
llvm/lib/Target/ARC/MCTargetDesc/ARCMCAsmInfo.cpp
llvm/lib/Target/ARC/MCTargetDesc/ARCMCAsmInfo.h
llvm/lib/Target/ARC/MCTargetDesc/ARCMCTargetDesc.cpp
llvm/lib/Target/ARC/MCTargetDesc/ARCMCTargetDesc.h
llvm/lib/Target/ARC/MCTargetDesc/CMakeLists.txt
llvm/lib/Target/ARC/MCTargetDesc/LLVMBuild.txt
llvm/lib/Target/ARC/TargetInfo/ARCTargetInfo.cpp
llvm/lib/Target/ARC/TargetInfo/CMakeLists.txt
llvm/lib/Target/ARC/TargetInfo/LLVMBuild.txt
llvm/lib/Target/LLVMBuild.txt
llvm/test/CodeGen/ARC/alu.ll
llvm/test/CodeGen/ARC/brcc.ll
llvm/test/CodeGen/ARC/call.ll
llvm/test/CodeGen/ARC/ldst.ll
llvm/test/CodeGen/ARC/lit.local.cfg
llvm/test/MC/Disassembler/ARC/alu.txt
llvm/test/MC/Disassembler/ARC/br.txt
llvm/test/MC/Disassembler/ARC/ldst.txt
llvm/test/MC/Disassembler/ARC/lit.local.cfg
llvm/test/MC/Disassembler/ARC/misc.txt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36331.111538.patch
Type: text/x-patch
Size: 231374 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170817/e1194662/attachment-0001.bin>
More information about the llvm-commits
mailing list