[PATCH] D36675: [ARM][Compiler-rt] Fix AEABI builtins to correctly pass arguments to non-AEABI functions on HF targets

Oleg Ranevskyy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 16:16:28 PDT 2017


iid_iunknown added a comment.

> I'll need to work out why my target (default armv7--linux-gnueabihf) got rejected. As an aside it would be interesting to know what target you used?

Yes, I had to manually add `arm-target-arch` to available features to enable these tests. 
Seems we can fix this by handling the ARM architectures similarly to `x86` (test/lit.common.cfg):

  if target_arch in ['x86_64', 'i386', 'i686']:
    config.available_features.add('x86-target-arch')

For ARM we now have only

  config.available_features.add(target_arch + '-target-arch')

so the `armv7--linux-gnueabihf` triple gives us `armv7-target-arch` that does not match the test's requirements.


Repository:
  rL LLVM

https://reviews.llvm.org/D36675





More information about the llvm-commits mailing list