[PATCH] D36675: [ARM][Compiler-rt] Fix AEABI builtins to correctly pass arguments to non-AEABI functions on HF targets

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

Thanks for making the changes. If this is covered by an existing test case I'm happy.

> This problem was caught using the standard compiler-rt test suite :) The tests are `test/builtins/Unit/arm/aeabi_cfcmpeq_test.c` and `test/builtins/Unit/arm/aeabi_cdcmpeq_test.c`.
>  For `aeabi_cfcmpeq_test.c` the call sequence looks like this:
> 
>   test -> __aeabi_cfcmpeq -> __aeabi_cfcmple -> __aeabi_fcmpeq -> __eqsf2
> 
> However, I can't find an LLVM buildbot that builds and runs the compiler-rt tests for ARM.

Interesting; I've used a cross-compilation of compiler-rt for ARM using qemu-arm to run the tests, sadly when I look at the logs in more detail I get

  UNSUPPORTED: Builtins-armhf-linux :: arm/aeabi_cdcmple_test.c (3 of 194)
  Test requires the following unavailable features: arm-target-arch || armv6m-target-arch

I'll need to work out why my target (default armv7--linux-gnueabihf) got rejected. As an aside it would be interesting to know what target you used?

Ideally it would be great to get compiler-rt able to build and run its tests for all the ARM architectures running via QEMU as a buildbot that could build all the supported platforms would be much faster than a native build-bot, and may be the only way for the M class builds.


Repository:
  rL LLVM

https://reviews.llvm.org/D36675