[PATCH] D36738: [test-suite] Adding miniXyce Benchmark
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 15 14:27:38 PDT 2017
MatzeB added a comment.
This also seems to produce intermediate files:
- Doing I/O in a compiler benchmark is generally a bad smell: We want to benchmark the CPU not the I/O subsystem. It may be fine if the I/O part doesn't dominate the runtime and is simple enough, but if there is an easy way around it that would be nice.
- If you create new files, I'd suggest to accept a full pathname on the commandline and specifying a path using `${CMAKE_CURRENT_BINARY_DIRECTORY}` placing files in the source directory can lead to race conditions if multiple builds (in different build directories) use the same sourcecode checkout. We also generally shouldn't assume the source checkout to be writable for benchmarks.
https://reviews.llvm.org/D36738
More information about the llvm-commits
mailing list