[PATCH] D36738: [test-suite] Adding miniXyce Benchmark

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 14:17:23 PDT 2017


MatzeB added a comment.

- Integration looks good to me.
- Maybe put the information from the patch description into a README file in the benchmark directory?
- On my macOS x86_64 system it compiles warning free but fails to verify:

  $ diff -u /Users/mbraun/dev/test-suite/build/MultiSource/Benchmarks/DOE-ProxyApps-C++/miniXyce/Output/miniXyce.test.out /Users/mbraun/dev/test-suite/MultiSource/Benchmarks/DOE-ProxyApps-C++/miniXyce/miniXyce.reference_output
  --- /Users/mbraun/dev/test-suite/build/MultiSource/Benchmarks/DOE-ProxyApps-C++/miniXyce/Output/miniXyce.test.out	2017-08-15 14:10:36.000000000 -0700
  +++ /Users/mbraun/dev/test-suite/MultiSource/Benchmarks/DOE-ProxyApps-C++/miniXyce/miniXyce.reference_output	2017-08-15 14:09:10.000000000 -0700
  @@ -32,5 +32,5 @@
     GMRES_tolerance: 1e-06
     GMRES_subspace_dim: 10
     GMRES_average_iters: 5
  -  GMRES_average_res: 5.65781e-16
  +  GMRES_average_res: 5.79223e-16
   exit 0



================
Comment at: LICENSE.TXT:87
 XSBench:            llvm-test/MultiSource/Benchmarks/DOE-ProxyApps-C/XSBench
+miniXyce:              llvm-test/MultiSource/Benchmarks/DOE-ProxyApps-C++/miniXyce
 Fhourstones:        llvm-test/MultiSource/Benchmarks/Fhourstones
----------------
misindentend (tabs vs spaces?)


https://reviews.llvm.org/D36738





More information about the llvm-commits mailing list