[PATCH] D36396: [AArch64] Do not promote f16 when subtarget HasFullFP16
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 15 09:01:07 PDT 2017
SjoerdMeijer updated this revision to Diff 111181.
SjoerdMeijer added a comment.
I forgot to address some of Oliver's earlier comments:
- I have added fixes for the conversion functions, and modified the tests,
- I will address the codegen for copysign in a follow up patch, because it it requires a bit of custom lowering.
About the newly added immediate tests:
- I have added (even) more tests. Edge cases is a bit meaningless for 8-bit fp immediates, because there are many (the ARMARM shows a table with accepted immediates), but this now covers minimum/maximum values.
- I have fixed the spell error, just only for those pedantic natives. ;-)
https://reviews.llvm.org/D36396
Files:
lib/Target/AArch64/AArch64ISelLowering.cpp
test/CodeGen/AArch64/f16-imm.ll
test/CodeGen/AArch64/f16-instructions.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36396.111181.patch
Type: text/x-patch
Size: 62035 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170815/f2dbdd29/attachment.bin>
More information about the llvm-commits
mailing list