[PATCH] D36396: [AArch64] Do not promote f16 when subtarget HasFullFP16

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: test/CodeGen/AArch64/f16-imm.ll:2
+; RUN: llc < %s -mtriple=aarch64-none-eabi -mattr=+fullfp16 | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-ILEGAL
+; RUN: llc < %s -mtriple=aarch64-none-eabi -mattr=-fullfp16 | FileCheck %s --check-prefix=CHECK-NOFP16 --check-prefix=CHECK-ILEGAL
+
----------------
A pedantic native speaker may point out that's its 'illegal'... ;)


================
Comment at: test/CodeGen/AArch64/f16-imm.ll:21
+
+; Here we test fp literal 32.0f16, which is not a legal f16 immediate even
+; when FP16 is enabled
----------------
I think it would be a good idea to add the tests that cover the edge cases too, so that the minimal and maximum values are shown to be accepted correctly.


https://reviews.llvm.org/D36396