[PATCH] D36313: [llvm-dwarfdump] - Print section name and index when dumping .debug_info ranges

[David Blaikie via llvm-commits]

On Tue, Aug 15, 2017 at 5:33 AM George Rimar via Phabricator <
reviews at reviews.llvm.org> wrote:

> grimar added a comment.
>
> In https://reviews.llvm.org/D36313#841530, @dblaikie wrote:
>
> > Looks OK to me - though please refactor the section name/uniqueness
> gathering so it's done once (probably lazily) rather than every time a
> range is dumped.
>
>
> Thanks, David ! I'll post refactoring patch soon.
>

Oh, I meant to suggest you should make the change before committing, but
not wait for another round of review if it seemed simple/obvious enough (&
we'd handle anything in post-commit review - unless in trying to implement
it it seemed nonobvious/more complicated than might be expected, etc).


>
>
> https://reviews.llvm.org/D36313
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170815/987cc384/attachment.html>