<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Tue, Aug 15, 2017 at 5:33 AM George Rimar via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">grimar added a comment.<br>
<br>
In <a href="https://reviews.llvm.org/D36313#841530" rel="noreferrer" target="_blank">https://reviews.llvm.org/D36313#841530</a>, @dblaikie wrote:<br>
<br>
> Looks OK to me - though please refactor the section name/uniqueness gathering so it's done once (probably lazily) rather than every time a range is dumped.<br>
<br>
<br>
Thanks, David ! I'll post refactoring patch soon.<br></blockquote><div><br>Oh, I meant to suggest you should make the change before committing, but not wait for another round of review if it seemed simple/obvious enough (& we'd handle anything in post-commit review - unless in trying to implement it it seemed nonobvious/more complicated than might be expected, etc).<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
<a href="https://reviews.llvm.org/D36313" rel="noreferrer" target="_blank">https://reviews.llvm.org/D36313</a><br>
<br>
<br>
<br>
</blockquote></div></div>