[compiler-rt] r310800 - Enable profile on NetBSD

[Vedant Kumar via llvm-commits]

I'm just echoing what I've stated in the review (https://reviews.llvm.org/D36603 <https://reviews.llvm.org/D36603>).

It's not a good idea to commit something that causes test failures. Please fix or revert this.

vedant

> On Aug 13, 2017, at 1:18 PM, Kamil Rytarowski via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: kamil
> Date: Sun Aug 13 13:18:15 2017
> New Revision: 310800
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=310800&view=rev
> Log:
> Enable profile on NetBSD
> 
> Summary:
> make check-profile:
> 
> Failing Tests (2):
>    Profile-i386 :: instrprof-dlopen.test
>    Profile-x86_64 :: instrprof-dlopen.test
> 
>  Expected Passes    : 64
>  Unsupported Tests  : 42
>  Unexpected Failures: 2
> 
> Sponsored by <The NetBSD Foundation>
> 
> Reviewers: joerg, vitalybuka, kcc, filcab, fjricci
> 
> Reviewed By: vitalybuka
> 
> Subscribers: vsk, llvm-commits, srhines, mgorny, #sanitizers
> 
> Tags: #sanitizers
> 
> Differential Revision: https://reviews.llvm.org/D36603
> 
> Modified:
>    compiler-rt/trunk/cmake/config-ix.cmake
>    compiler-rt/trunk/test/profile/lit.cfg
> 
> Modified: compiler-rt/trunk/cmake/config-ix.cmake
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/config-ix.cmake?rev=310800&r1=310799&r2=310800&view=diff
> ==============================================================================
> --- compiler-rt/trunk/cmake/config-ix.cmake (original)
> +++ compiler-rt/trunk/cmake/config-ix.cmake Sun Aug 13 13:18:15 2017
> @@ -519,7 +519,7 @@ else()
> endif()
> 
> if (PROFILE_SUPPORTED_ARCH AND NOT LLVM_USE_SANITIZER AND
> -    OS_NAME MATCHES "Darwin|Linux|FreeBSD|Windows|Android")
> +    OS_NAME MATCHES "Darwin|Linux|FreeBSD|Windows|Android|NetBSD")
>   set(COMPILER_RT_HAS_PROFILE TRUE)
> else()
>   set(COMPILER_RT_HAS_PROFILE FALSE)
> 
> Modified: compiler-rt/trunk/test/profile/lit.cfg
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/profile/lit.cfg?rev=310800&r1=310799&r2=310800&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/profile/lit.cfg (original)
> +++ compiler-rt/trunk/test/profile/lit.cfg Sun Aug 13 13:18:15 2017
> @@ -78,7 +78,7 @@ config.substitutions.append( ("%clangxx_
> 
> config.substitutions.append( ("%clang_lto_profgen=", build_invocation(clang_cflags, True) + " -fprofile-instr-generate=") )
> 
> -if config.host_os not in ['Darwin', 'FreeBSD', 'Linux']:
> +if config.host_os not in ['Darwin', 'FreeBSD', 'Linux', 'NetBSD']:
>   config.unsupported = True
> 
> if config.target_arch in ['armv7l']:
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170813/9c984a40/attachment.html>