<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I'm just echoing what I've stated in the review (<a href="https://reviews.llvm.org/D36603" class="">https://reviews.llvm.org/D36603</a>).<div class=""><br class=""></div><div class="">It's not a good idea to commit something that causes test failures. Please fix or revert this.<div class=""><br class=""></div><div class="">vedant</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 13, 2017, at 1:18 PM, Kamil Rytarowski via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Author: kamil<br class="">Date: Sun Aug 13 13:18:15 2017<br class="">New Revision: 310800<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=310800&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=310800&view=rev</a><br class="">Log:<br class="">Enable profile on NetBSD<br class=""><br class="">Summary:<br class="">make check-profile:<br class=""><br class="">Failing Tests (2):<br class=""> Profile-i386 :: instrprof-dlopen.test<br class=""> Profile-x86_64 :: instrprof-dlopen.test<br class=""><br class=""> Expected Passes : 64<br class=""> Unsupported Tests : 42<br class=""> Unexpected Failures: 2<br class=""><br class="">Sponsored by <The NetBSD Foundation><br class=""><br class="">Reviewers: joerg, vitalybuka, kcc, filcab, fjricci<br class=""><br class="">Reviewed By: vitalybuka<br class=""><br class="">Subscribers: vsk, llvm-commits, srhines, mgorny, #sanitizers<br class=""><br class="">Tags: #sanitizers<br class=""><br class="">Differential Revision: <a href="https://reviews.llvm.org/D36603" class="">https://reviews.llvm.org/D36603</a><br class=""><br class="">Modified:<br class=""> compiler-rt/trunk/cmake/config-ix.cmake<br class=""> compiler-rt/trunk/test/profile/lit.cfg<br class=""><br class="">Modified: compiler-rt/trunk/cmake/config-ix.cmake<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/config-ix.cmake?rev=310800&r1=310799&r2=310800&view=diff" class="">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/config-ix.cmake?rev=310800&r1=310799&r2=310800&view=diff</a><br class="">==============================================================================<br class="">--- compiler-rt/trunk/cmake/config-ix.cmake (original)<br class="">+++ compiler-rt/trunk/cmake/config-ix.cmake Sun Aug 13 13:18:15 2017<br class="">@@ -519,7 +519,7 @@ else()<br class=""> endif()<br class=""><br class=""> if (PROFILE_SUPPORTED_ARCH AND NOT LLVM_USE_SANITIZER AND<br class="">- OS_NAME MATCHES "Darwin|Linux|FreeBSD|Windows|Android")<br class="">+ OS_NAME MATCHES "Darwin|Linux|FreeBSD|Windows|Android|NetBSD")<br class=""> set(COMPILER_RT_HAS_PROFILE TRUE)<br class=""> else()<br class=""> set(COMPILER_RT_HAS_PROFILE FALSE)<br class=""><br class="">Modified: compiler-rt/trunk/test/profile/lit.cfg<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/profile/lit.cfg?rev=310800&r1=310799&r2=310800&view=diff" class="">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/profile/lit.cfg?rev=310800&r1=310799&r2=310800&view=diff</a><br class="">==============================================================================<br class="">--- compiler-rt/trunk/test/profile/lit.cfg (original)<br class="">+++ compiler-rt/trunk/test/profile/lit.cfg Sun Aug 13 13:18:15 2017<br class="">@@ -78,7 +78,7 @@ config.substitutions.append( ("%clangxx_<br class=""><br class=""> config.substitutions.append( ("%clang_lto_profgen=", build_invocation(clang_cflags, True) + " -fprofile-instr-generate=") )<br class=""><br class="">-if config.host_os not in ['Darwin', 'FreeBSD', 'Linux']:<br class="">+if config.host_os not in ['Darwin', 'FreeBSD', 'Linux', 'NetBSD']:<br class=""> config.unsupported = True<br class=""><br class=""> if config.target_arch in ['armv7l']:<br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></div></blockquote></div><br class=""></div></div></body></html>