[PATCH] D35918: [GVNHoist] Factor out reachability to search for anticipable instructions quickly

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added inline comments.


================
Comment at: lib/Transforms/Scalar/GVNHoist.cpp:751
+        DEBUG(for (auto B : IDFBlocks) dbgs() << "\nPDF: " << B->getName(););
+        // continue; // Cannot find a unique common-dom-frontier for set of VNs.
+      }
----------------
dberlin wrote:
> What are you really trying to do here? (IE why is the continue commented out)
That was from the early stage when I only handled unique post-dom frontiers. I've removed those lines.


================
Comment at: lib/Transforms/Scalar/GVNHoist.cpp:954
           MemoryAccess *Def = OldMemAcc->getDefiningAccess();
-          NewMemAcc =
-            MSSAUpdater->createMemoryAccessInBB(Repl, Def, HoistPt, MemorySSA::End);
+          NewMemAcc = MSSAUpdater->createMemoryAccessInBB(Repl, Def, HoistPt,
+                                                          MemorySSA::End);
----------------
dberlin wrote:
> I think since you wrote this we added moving functions you could use here.
> 
I'll look into it and update this code. Thanks for the feedback.


https://reviews.llvm.org/D35918