[PATCH] D36227: [ELF] - LTO: Try to be option compatible with the gold plugin.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 08:00:03 PDT 2017

grimar added inline comments.

Comment at: ELF/Driver.cpp:703
+  for (auto *Arg : Args.filtered(OPT_plugin_opt, OPT_plugin_opt_eq)) {
+    StringRef S = Arg->getValue();
ruiu wrote:
> plugin_opt_eq is an alias for plugin_opt. Do you have to pass both?
I'll recheck.

Comment at: ELF/Driver.cpp:716
+    // Ignore some options always passed by gcc.
+    else if (!S.startswith("/") && !S.startswith("-fresolution=") &&
+             !S.startswith("-pass-through="))
ruiu wrote:
> What is '/'?
Line Rafael mentioned earlier:

//"Note that gcc has be bad habit of always passing some options, so we
pretty much have to ignore those:

It is LTO wrapper which we should ignore:


More information about the llvm-commits mailing list