[PATCH] D36227: [ELF] - LTO: Try to be option compatible with the gold plugin.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 07:44:28 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Driver.cpp:703
 
+  for (auto *Arg : Args.filtered(OPT_plugin_opt, OPT_plugin_opt_eq)) {
+    StringRef S = Arg->getValue();
----------------
plugin_opt_eq is an alias for plugin_opt. Do you have to pass both?


================
Comment at: ELF/Driver.cpp:716
+    // Ignore some options always passed by gcc.
+    else if (!S.startswith("/") && !S.startswith("-fresolution=") &&
+             !S.startswith("-pass-through="))
----------------
What is '/'?


https://reviews.llvm.org/D36227





More information about the llvm-commits mailing list