[PATCH] D36544: [COFF] Add SymbolName as a distinct field in COFFImportFile
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 10 22:57:00 PDT 2017
mstorsjo added a comment.
Instead of this patch, we could also update`getNameType` to check for decoration, e.g like this:
if (!Sym.startswith("?") && Sym.find('@', 1) != Sym.npos)
return IMPORT_NAME_UNDECORATE;
This patch tries to get things back to match how things were in lld prior to factorizing it, while the snippet above takes it into a different direction. I'd appreciate if @ruiu could chime in on which direction is better to take here.
https://reviews.llvm.org/D36544
More information about the llvm-commits
mailing list