[PATCH] D36544: [COFF] Add SymbolName as a distinct field in COFFImportFile

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 22:31:14 PDT 2017


mstorsjo added inline comments.


================
Comment at: lib/Object/COFFImportFile.cpp:582
     if (E.isWeak()) {
       Members.push_back(OF.createWeakExternal(E.Name, E.ExtName, false));
       Members.push_back(OF.createWeakExternal(E.Name, E.ExtName, true));
----------------
Should we extend `isWeak()` to check `SymbolName` instead of `Name`, if set? Or just avoid touching the decoration altogether in llvm-dlltool D36548 if we want to create a weak alias?


https://reviews.llvm.org/D36544





More information about the llvm-commits mailing list