[PATCH] D36466: [ELF] - Do not omit common symbols when -Map is given.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 06:01:12 PDT 2017

grimar added inline comments.

Comment at: ELF/MapFile.cpp:61
+      } else if (auto *DC = dyn_cast<DefinedCommon>(B)) {
+        if (InX::Common)
+          V.push_back(cast<DefinedCommon>(B));
ruiu wrote:
> Why do you have to check this?
For -r/--no-define-common cases.
Otherwise getSectionSyms() would return map with key==null,
does not look clean an not useful 
(see my answer in this thread to Rafael about this place).


More information about the llvm-commits mailing list