[PATCH] D36466: [ELF] - Do not omit common symbols when -Map is given.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/MapFile.cpp:40
+typedef DenseMap<const SectionBase *, SmallVector<Defined *, 4>> SymbolMapTy;
+typedef DenseMap<Defined *, std::string> SymbolStringsMapTy;
 
----------------
Remove this typedef and inline.


================
Comment at: ELF/MapFile.cpp:61
+      } else if (auto *DC = dyn_cast<DefinedCommon>(B)) {
+        if (InX::Common)
+          V.push_back(cast<DefinedCommon>(B));
----------------
Why do you have to check this?


https://reviews.llvm.org/D36466