[PATCH] D36512: [ValueTracking] Honour recursion limit

[Chad Rosier via Phabricator via llvm-commits]

mcrosier added inline comments.


================
Comment at: lib/Analysis/ValueTracking.cpp:4534
 
   // The remaining tests are all recursive, so bail out if we hit the limit.
   if (Depth == MaxDepth)
----------------
davide wrote:
> mcrosier wrote:
> > Is this check still necessary?  I don't think it is, but of course, I'm the one who broke things in the first place.. :P
> I don't think so. I'd replace this with an assertion on trunk, but I'll keep it for safety when doing the backport to 5.
SGTM!


https://reviews.llvm.org/D36512