[PATCH] D36512: [ValueTracking] Honour recursion limit
Davide Italiano via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 9 08:00:15 PDT 2017
davide added a comment.
In https://reviews.llvm.org/D36512#836711, @mcrosier wrote:
> One small comment, but otherwise LGTM. Thanks, Davide.
Thanks for your review.
Comment at: lib/Analysis/ValueTracking.cpp:4534
// The remaining tests are all recursive, so bail out if we hit the limit.
if (Depth == MaxDepth)
> Is this check still necessary? I don't think it is, but of course, I'm the one who broke things in the first place.. :P
I don't think so. I'd replace this with an assertion on trunk, but I'll keep it for safety when doing the backport to 5.
More information about the llvm-commits