[llvm] r310242 - [asan] Fix asan dynamic shadow check before copyArgsPassedByValToAllocas

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 14:50:56 PDT 2017


Correct.
Thank you.

On Mon, Aug 7, 2017 at 2:49 PM, Hans Wennborg <hans at chromium.org> wrote:

> On Mon, Aug 7, 2017 at 12:35 AM, Vitaly Buka via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: vitalybuka
> > Date: Mon Aug  7 00:35:33 2017
> > New Revision: 310242
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=310242&view=rev
> > Log:
> > [asan] Fix asan dynamic shadow check before copyArgsPassedByValToAllocas
> >
> > Modified:
> >     llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
>
> I assume this is a follow-up fix to r310241? Please note that in the
> commit message.
>
> Since I merged r310241 to 5.0 I assumed this should be merged too.
>
> >
> > Modified: llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/
> Transforms/Instrumentation/AddressSanitizer.cpp?rev=
> 310242&r1=310241&r2=310242&view=diff
> > ============================================================
> ==================
> > --- llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
> (original)
> > +++ llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp Mon
> Aug  7 00:35:33 2017
> > @@ -756,7 +756,7 @@ struct FunctionStackPoisoner : public In
> >    bool runOnFunction() {
> >      if (!ClStack) return false;
> >
> > -    if (ClRedzoneByvalArgs && !ClForceDynamicShadow)
> > +    if (ClRedzoneByvalArgs && Mapping.Offset != kDynamicShadowSentinel)
> >        copyArgsPassedByValToAllocas();
> >
> >      // Collect alloca, ret, lifetime instructions etc.
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170807/1100e954/attachment.html>


More information about the llvm-commits mailing list