<div dir="ltr">Correct.<div>Thank you.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 7, 2017 at 2:49 PM, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, Aug 7, 2017 at 12:35 AM, Vitaly Buka via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: vitalybuka<br>
> Date: Mon Aug  7 00:35:33 2017<br>
> New Revision: 310242<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=310242&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=310242&view=rev</a><br>
> Log:<br>
> [asan] Fix asan dynamic shadow check before copyArgsPassedByValToAllocas<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Transforms/<wbr>Instrumentation/<wbr>AddressSanitizer.cpp<br>
<br>
</span>I assume this is a follow-up fix to r310241? Please note that in the<br>
commit message.<br>
<br>
Since I merged r310241 to 5.0 I assumed this should be merged too.<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> Modified: llvm/trunk/lib/Transforms/<wbr>Instrumentation/<wbr>AddressSanitizer.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=310242&r1=310241&r2=310242&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/Instrumentation/<wbr>AddressSanitizer.cpp?rev=<wbr>310242&r1=310241&r2=310242&<wbr>view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/lib/Transforms/<wbr>Instrumentation/<wbr>AddressSanitizer.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/<wbr>Instrumentation/<wbr>AddressSanitizer.cpp Mon Aug  7 00:35:33 2017<br>
> @@ -756,7 +756,7 @@ struct FunctionStackPoisoner : public In<br>
>    bool runOnFunction() {<br>
>      if (!ClStack) return false;<br>
><br>
> -    if (ClRedzoneByvalArgs && !ClForceDynamicShadow)<br>
> +    if (ClRedzoneByvalArgs && Mapping.Offset != kDynamicShadowSentinel)<br>
>        copyArgsPassedByValToAllocas()<wbr>;<br>
><br>
>      // Collect alloca, ret, lifetime instructions etc.<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>