[PATCH] D36380: [Polly][ForwardOpTree] Use known array content analysis to forward load instruction.

[Tobias Grosser via Phabricator via llvm-commits]

grosser accepted this revision.
grosser added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: include/polly/ZoneAlgo.h:83
+  ///  Combined access relations of all MK_Array write accesses (union of
+  ///  AllMayWrites and AllMustWrites).
+  /// { DomainWrite[] -> Element[] }
----------------
Two whitespaces at the beginning of the line?


================
Comment at: lib/Support/RegisterPasses.cpp:77
+    cl::Hidden, cl::location(PassPosition), cl::init(POSITION_EARLY),
+    cl::ZeroOrMore, cl::cat(PollyCategory));
 
----------------
I think we should enable this always. I suggest to remove this change.


================
Comment at: lib/Transform/ForwardOpTree.cpp:37
+             "-polly-position=before-vectorizer, off otherwise)"),
+    cl::cat(PollyCategory), cl::Optional);
+
----------------
We should always have it on, to make sure it is tested.


================
Comment at: lib/Transform/ForwardOpTree.cpp:210
+
+      // There might be multiple array elements the contain the same value, but
+      // choose only one of them. lexmin is used because it returns a one-value
----------------
THAT contain the same value


================
Comment at: lib/Transform/ForwardOpTree.cpp:289
+  /// @param AccessRelation The array element that each statement instance
+  /// accesses.
+  ///
----------------
Maybe align with the start of the descriptions?


https://reviews.llvm.org/D36380