[PATCH] D33880: COFF: Introduce LD shim around LINK

[Martell Malone via Phabricator via llvm-commits]

martell added a comment.

In https://reviews.llvm.org/D33880#831570, @mstorsjo wrote:

> If you're still too busy and don't mind, I could also take over trying to get this in a mergeable form.


I can be on this to ensure it gets merged, there were 2 reasons why I left this slide for awhile.
I was having an issue with llvm-dlltool where if I used `new` to create memory for the strings it would work but if I done it the correct way as rui instructed it was not working correctly.
We now know that was because we were writing the strings beforehand the entry thanks to you :) So the 2 bugs because of the location of the the allocation seemed to nullify each other to some degree.
Which left me a little confused. So I left the lld support slide until llvm-dlltool was merged and also at the time I had started a new job.

I can still be somewhat useful here because I understand what is going on.
Where I probably won't be of any use is on the unwind exceptions, so might be an idea to commandeer that differential?
I'm sure this is something you know a lot more about and I can probably learn a lot from the patch that gets merged for it.

Also I am not sure how extreme I should go with test cases here, how many existing tests will I amend to test the mingw driver.


Repository:
  rL LLVM

https://reviews.llvm.org/D33880