[PATCH] D33880: COFF: Introduce LD shim around LINK

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 4 02:42:11 PDT 2017


ruiu added a comment.

Please rename the directory MinGW, as MINGW is not an acronym.T



================
Comment at: MINGW/Driver.cpp:36
+namespace lld {
+namespace coff {
+namespace {
----------------
This should be mingw instead of coff.

Since you are writing code that is not in COFF directory, do not depend on anything in COFF directory, except elf::coff::link. Please remove dependency to COFF directory.


Repository:
  rL LLVM

https://reviews.llvm.org/D33880





More information about the llvm-commits mailing list