[PATCH] D36285: [PDB] Fix section contributions

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 14:03:12 PDT 2017


zturner accepted this revision.
zturner added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/DebugInfo/PDB/Native/DbiStreamBuilder.h:75-77
+  void addSectionContrib(SectionContrib SC) {
+    SectionContribs.emplace_back(SC);
+  }
----------------
Pass by `const&`?


https://reviews.llvm.org/D36285





More information about the llvm-commits mailing list