[PATCH] D36285: [PDB] Fix section contributions

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 13:48:42 PDT 2017


rnk created this revision.
Herald added a subscriber: hiraditya.

PDB section contributions are supposed to use output section indices and
offsets, not input section indices and offsets.

This allows the debugger to look up the index of the module that it
should look up in the modules stream for symbol information. With this
change, windbg can now find line tables, but it still cannot print local
variables.

Fixes PR34048


https://reviews.llvm.org/D36285

Files:
  lld/COFF/PDB.cpp
  lld/COFF/PDB.h
  lld/COFF/Writer.cpp
  lld/test/COFF/pdb-publics-import.test
  lld/test/COFF/pdb.test
  llvm/include/llvm/DebugInfo/PDB/Native/DbiStreamBuilder.h
  llvm/lib/DebugInfo/PDB/Native/DbiStreamBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36285.109624.patch
Type: text/x-patch
Size: 10714 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170803/44f68b30/attachment.bin>


More information about the llvm-commits mailing list