[PATCH] D35945: [ELF] - Linkerscript: better diagnostic for INPUT/GROUP commands.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/ScriptParser.cpp:312
   expect("(");
-  while (!Error && !consume(")")) {
-    if (consume("AS_NEEDED"))
+  while (!Error && !consume(")") && !ErrorCount) {
+    if (consume("AS_NEEDED")) {
----------------
grimar wrote:
> ruiu wrote:
> > Ditto
> Why ? I think readAsNeeded() can set Error.
Whenever error is true, ErrorCount should be greater than 0.


https://reviews.llvm.org/D35945