[PATCH] D35945: [ELF] - Linkerscript: better diagnostic for INPUT/GROUP commands.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 04:41:28 PDT 2017


grimar added inline comments.


================
Comment at: ELF/ScriptParser.cpp:312
   expect("(");
-  while (!Error && !consume(")")) {
-    if (consume("AS_NEEDED"))
+  while (!Error && !consume(")") && !ErrorCount) {
+    if (consume("AS_NEEDED")) {
----------------
ruiu wrote:
> Ditto
Why ? I think readAsNeeded() can set Error.


https://reviews.llvm.org/D35945





More information about the llvm-commits mailing list