[PATCH] D36107: [PostDom] document the current handling of infinite loops and unreachables

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 21:12:53 PDT 2017


On Thu, Aug 3, 2017, at 02:19, Jakub Kuderski via Phabricator via
llvm-commits wrote:
> kuhar added a comment.
> 
> I've just realized that I didn't notice the TODOs  in this patch when I
> did a code review for it.
> 
>   // TODO: Can we change the PDT definition such that C remains part of
>   the
>   //       CFG, at best without loosing the dominance relation D postdom
>   B.
> 
> I don't think we reached an agreement on the second part of the TODO, as
> the `"at best"` might imply. Could you reword the second part of the
> comment to be less ambiguous and not to suggest that?

I can just drop it.There is no need to sneak in TODOs to reach an
agreement.
Hopefully our discussion is fruit
 
> And a very minor nitpick: isn't it supposed to be s/loosing/losing? :)

Best,
Tobias


More information about the llvm-commits mailing list