[PATCH] D36107: [PostDom] document the current handling of infinite loops and unreachables

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

I've just realized that I didn't notice the TODOs  in this patch when I did a code review for it.

  // TODO: Can we change the PDT definition such that C remains part of the
  //       CFG, at best without loosing the dominance relation D postdom B.

I don't think we reached an agreement on the second part of the TODO, as the `"at best"` might imply. Could you reword the second part of the comment to be less ambiguous and not to suggest that?

And a very minor nitpick: isn't it supposed to be s/loosing/losing? :)


Repository:
  rL LLVM

https://reviews.llvm.org/D36107