[PATCH] D36233: [ThinLTO] Add FunctionAttrs to ThinLTO index

[Charles Saternos via Phabricator via llvm-commits]

ncharlie added a comment.

In https://reviews.llvm.org/D36233#829601, @tejohnson wrote:

> I think you simply need to bump the INDEX_VERSION (in BitcodeWriter.cpp). Looks like you left it at 3, and your reads of the new flags are checking if the version is >=3, but it should presumably be reading the new field at version > 3 with the new version set to 4.


OK, I didn't realize that version number was just used for bookkeeping the bitcode format. That was what I needed to do.

> I don't think you're populating these in any way. For now I would leave this out of the patch and focus on the function summary part of it only.

Good point - I forgot to remove the MemoryAccess field. I'll rip it out from the bitcode and the index (and revert those parts of the tests).


https://reviews.llvm.org/D36233