[PATCH] D36233: [ThinLTO] Add FunctionAttrs to ThinLTO index

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D36233#829574, @ncharlie wrote:

> In https://reviews.llvm.org/D36233#829465, @mehdi_amini wrote:
>
> > In https://reviews.llvm.org/D36233#829464, @ncharlie wrote:
> >
> > > In https://reviews.llvm.org/D36233#829454, @mehdi_amini wrote:
> > >
> > > > What makes them fail?
> > >
> > >
> > > They're missing the new field I added to the bitcode, so they fail a bounds-check assert.
> >
> >
> > I'm glad we have these tests then :)
> >  That's a real bug in your code: the bitcode has to be designed so that you can read back older version.
>
>
> OK, I'll move that field then.


I think you simply need to bump the INDEX_VERSION (in BitcodeWriter.cpp). Looks like you left it at 3, and your reads of the new flags are checking if the version is >=3, but it should presumably be reading the new field at version > 3 with the new version set to 4.


https://reviews.llvm.org/D36233