[PATCH] D36212: [lit] Use Visual Studio build config when testing

Greg Bedwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 08:26:08 PDT 2017


gbedwell added a comment.

In https://reviews.llvm.org/D36212#829005, @modocache wrote:

> @gbedwell It seems like your diff is more in line with how this fix should be written. Would you care to commit it or submit it for review? Or if you don't have the time I would be happy to.


I'm happy either way!  I was going to put the patch up for review but I noticed that after running some lit tests there appear to be some artifacts being created and left over outside of the build directory.  I'm just rebuilding without the patch now to see whether it's that which is causing them to end up there or if it was happening anyway.  For reference, these are:

  Untracked files:
    (use "git add <file>..." to include in what will be committed)
  
          utils/lit/tests/Inputs/max-failures/Output/
          utils/lit/tests/Inputs/shtest-format/external_shell/Output/
          utils/lit/tests/Inputs/shtest-output-printing/Output/
          utils/lit/tests/Inputs/shtest-shell/Output/
          utils/lit/tests/Inputs/shtest-timeout/Output/

Unfortunately, I'm leaving the office early today so have run out of time.  If you want to carry on with it please do, otherwise I'll aim to put something up tomorrow morning (UK time).


https://reviews.llvm.org/D36212





More information about the llvm-commits mailing list