[PATCH] D36212: [lit] Use Visual Studio build config when testing

[Brian Gesiak via Phabricator via llvm-commits]

modocache added a comment.

> Apologies for jumping in on your patch here.

Not at all, I learned a lot! I was just trying to fix a buildbot that used Visual Studio, I had no idea the build systems in Xcode and VS both worked this way.

> I tried the following patch which seems to do the trick. What do you think?

Looks great! It's funny, I also looked at `llvm/test/lit.*` in order to spot why this wasn't working, and noticed the fact that `LLVM_BINARY_TOOLS_DIR` was being used here instead of `LLVM_TOOLS_DIR`, but where I fell short was noticing `LIT_SITE_CFG_IN_HEADER`. Thanks to you and @chapuni for pointing that out!

@gbedwell It seems like your diff is more in line with how this fix should be written. Would you care to commit it or submit it for review? Or if you don't have the time I would be happy to.


https://reviews.llvm.org/D36212