[PATCH] D36094: [globalisel][tablegen] Do not merge memoperands from instructions that weren't in the match.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 02:33:32 PDT 2017


fhahn added a comment.

I'll commit https://reviews.llvm.org/D36151 after this one goes in, so we see if this change fixes the buildbot



================
Comment at: include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h:377
+      int64_t MergeInsnID = -1;
+      while ((MergeInsnID = MatchTable[CurrentIdx++]) != -1) {
+        DEBUG(dbgs() << ", MIs[" << MergeInsnID << "]");
----------------
Does this mean that now we are advancing CurrentIdx till the end? Could this have an impact on further actions after GIR_MergeMemOperands?


https://reviews.llvm.org/D36094





More information about the llvm-commits mailing list